cam_hal: add guard in cam_task() so DMA transfers cannot exceed image slot size #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
Jul 18, 2025
|
have you been able to confirm such issue? |
|
No, because another bug currently blocks the usage for me. I'm working on a fix for that. But since we just guess the slot size of the image, based on the settings rather than observations, and it can be overwritten by build flags IIRC, it's a reasonable guard to prevent more than copy operations than we got space. |
… slot size Previously there is no limit how much data would be transferred via DMA from the camera. Added a DMA overflow detection block in cam_task() so the driver stops if the number of frame copies exceeds the is reaching the maximum amount of storage allocated in PSRAM.
RubenKelevra
force-pushed
the
bugfix/camtask_dma_overflow_detection
branch
from
54e0438 to
309999a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously there is no limit how much data would be transferred via DMA from the camera (in psram_mode).
Added a DMA overflow detection block in cam_task() so the driver stops if the number of frame copies exceeds the is reaching the maximum amount of storage allocated in PSRAM.
Checklist
Before submitting a Pull Request, please ensure the following: